Re: BUG #5656: parameter 'client_min_messages' accept values not listed in enumvals - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #5656: parameter 'client_min_messages' accept values not listed in enumvals
Date
Msg-id 10365.1284490620@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #5656: parameter 'client_min_messages' accept values not listed in enumvals  (Euler Taveira de Oliveira <euler@timbira.com>)
Responses Re: BUG #5656: parameter 'client_min_messages' accept values not listed in enumvals  (Euler Taveira de Oliveira <euler@timbira.com>)
List pgsql-bugs
Euler Taveira de Oliveira <euler@timbira.com> writes:
> Bruce Momjian escreveu:
>> We are basically reusing the same validation code for this and other
>> min_messages settings.
>>
> No, we have two enums ({client,server}_message_level_options); I don't
> understand why we should have these options in client_min_messages enum.

I believe the reasoning was that we shouldn't arbitrarily refuse values
that have a legal interpretation, but that we should hide them in the
pg_settings view if they aren't especially sensible to use.  You might
care to go back and consult the archives for the discussions that led up
to putting a "hidden value" feature into the guc-enum code.  ISTM your
argument can be reduced to "there should be no hidden values ever", but
I doubt we're going to buy that.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Euler Taveira de Oliveira
Date:
Subject: Re: BUG #5656: parameter 'client_min_messages' accept values not listed in enumvals
Next
From: Thomas Bahls
Date:
Subject: Re: BUG #5657: wrong entry in sql_features