Re: boolean in C - Mailing list pgsql-hackers

From Tom Lane
Subject Re: boolean in C
Date
Msg-id 10356.1247758976@sss.pgh.pa.us
Whole thread Raw
In response to Re: boolean in C  (Grzegorz Jaskiewicz <gj@pointblue.com.pl>)
List pgsql-hackers
Grzegorz Jaskiewicz <gj@pointblue.com.pl> writes:
> On 16 Jul 2009, at 15:17, Tom Lane wrote:
>> That's hardly going to improve readability for anyone.  Also, it will
>> flat out not work for the catalog struct declarations.  When we say
>> "bool relhasindex;" the compiler had better think that that's a
>> one-byte field.

> Sure, but I would certainly hope, there's not too many places where  
> you actually convert it from disc representation, to internal and vice  
> versa.

We don't "convert" --- it's expected to be the same representation.
As for not too many of them, I think grepping for references to bool
catalog fields will show you differently ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Kenneth Marshall
Date:
Subject: Re: Re: Review remove {join,from}_collapse_limit, add enable_join_ordering
Next
From: Andres Freund
Date:
Subject: Re: Review remove {join,from}_collapse_limit, add enable_join_ordering