Re: On login trigger: take three - Mailing list pgsql-hackers

From Tom Lane
Subject Re: On login trigger: take three
Date
Msg-id 1035539.1648507247@sss.pgh.pa.us
Whole thread Raw
In response to Re: On login trigger: take three  (Andres Freund <andres@anarazel.de>)
Responses Re: On login trigger: take three
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-03-28 23:27:56 +0200, Daniel Gustafsson wrote:
>> Do you think this potential foot-gun is scary enough to reject this patch?
>> There are lots of creative ways to cause Nagios alerts from ones database, but
>> this has the potential to do so with a small bug in userland code.  Still, I
>> kind of like the feature so I'm indecisive.

> It does seem like a huge footgun. But also kinda useful. So I'm really +-0.

An on-login trigger is *necessarily* a foot-gun; I don't see that this
particular failure mode makes it any worse than it would be anyway.
There has to be some not-too-difficult-to-use way to bypass a broken
login trigger.  Assuming we are happy with the design for doing that,
might as well accept the hazards.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs
Next
From: Andrew Dunstan
Date:
Subject: Re: [RFC] building postgres with meson -v8