Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Negative Transition Aggregate Functions (WIP) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date
Msg-id 10350.1388689817@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Negative Transition Aggregate Functions (WIP)  ("Erik Rijkers" <er@xs4all.nl>)
List pgsql-hackers
Tree view 
"Erik Rijkers" <er@xs4all.nl> writes:
> The TRACE_POSTGRESQL_SORT_DONE warnings were not from your patch; sorry about that. They occur on HEAD too (with a
debug
> compile).

> tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
>   TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
>                                             ^
> tuplesort.c:935:2: note: in expansion of macro �
>   TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);


FWIW, I don't see any such warnings on either of the machines I have that
will accept --enable-dtrace.  state->tapeset is a pointer, so these
warnings look a tad bogus.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: preserving forensic information when we freeze
Next
From: Alvaro Herrera
Date:
Subject: Re: more psprintf() use