Re: Repeated crashes in GENERATED ... AS IDENTITY tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Repeated crashes in GENERATED ... AS IDENTITY tests
Date
Msg-id 10345.1524172987@sss.pgh.pa.us
Whole thread Raw
In response to Re: Repeated crashes in GENERATED ... AS IDENTITY tests  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Event trigger bugs (was Re: Repeated crashes in GENERATED ... AS IDENTITY tests)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Of the machines you listed, conchuela has gdb installed, which gives us
> a nice backtrace of the crash, pasted below, which seems to blame event
> triggers.  Of the tests in the same parallel group as identity, the test
> fast_default seems to be the only one with an event trigger and was
> added on March 28th by 16828d5c0273.  That combination seems to explain
> why the crashes appeared late ...

Hm.  Our past policy has been that tests involving event triggers must not
run in parallel with any other test, precisely because the event triggers
interact with anything else happening at the same time, and will
inevitably create irreproducible test failures.

I'm inclined to say that whether or not there's a bug here (and there
well may be, it doesn't seem like a crash is a good thing), this is
bad test design and we need to change it.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Documentation for bootstrap data conversion
Next
From: Tom Lane
Date:
Subject: Event trigger bugs (was Re: Repeated crashes in GENERATED ... AS IDENTITY tests)