Re: [HACKERS] possible self-deadlock window after bad ProcessStartupPacket - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] possible self-deadlock window after bad ProcessStartupPacket
Date
Msg-id 10309.1498158631@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] possible self-deadlock window after badProcessStartupPacket  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] possible self-deadlock window after badProcessStartupPacket  (Nico Williams <nico@cryptonector.com>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> Or, probably more robust: Simply _exit(2) without further ado, and rely
> on postmaster to output an appropriate error message. Arguably it's not
> actually useful to see hundreds of "WARNING: terminating connection because of
> crash of another server process" messages in the log anyway.

At that point you might as well skip the entire mechanism and go straight
to SIGKILL.  IMO the only reason quickdie() exists at all is to try to
send a helpful message to the client.  And it is helpful --- your attempt
to claim that it isn't sounds very much like wishful thinking.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: [HACKERS] Guarding against bugs-of-omission in initdb's setup_depend
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Adding support for Default partition in partitioning