Re: LogicalChanges* and LogicalSubxact* wait events are never reported - Mailing list pgsql-hackers

From Masahiro Ikeda
Subject Re: LogicalChanges* and LogicalSubxact* wait events are never reported
Date
Msg-id 102b9e3c-fa5f-9807-e817-6e9e55fdaff6@oss.nttdata.com
Whole thread Raw
In response to Re: LogicalChanges* and LogicalSubxact* wait events are never reported  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers

On 2021/10/21 17:40, Amit Kapila wrote:
> On Wed, Oct 20, 2021 at 3:46 PM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:
>>
>> On 2021/10/20 18:17, Amit Kapila wrote:
>>> On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael@paquier.xyz> wrote:
>>>>
>>>> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote:
>>>>> If my understanding is right, it's better to remove them since they make
>>>>> users confused. Please see the attached patch. I confirmed that to make
>>>>> check-world passes all tests.
>>>>
>>>> Yeah, I don't see the point in keeping these events around if they are
>>>> not used.  Perhaps Amit has some plans for them, though.
>>>>
>>>
>>> No, there is no plan for these. As far as I remember, during
>>> development, we have decided to use BufFile interface and forgot to
>>> remove these events which were required by the previous versions of
>>> the patch. I'll take care of this.
>>>
>>> Thanks for the report and patch!
>> Thanks for your replies and for handling it!
>>
> 
> Pushed!

Thanks!

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Drop replslot after pgstat_shutdown cause assert coredump