Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure". - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
Date
Msg-id 10269.1502134598@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Record full paths of programs sought by"configure".  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Record full paths of programs sought by"configure".  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-committers
Tree view 
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 08/07/2017 03:21 PM, Tom Lane wrote:
>> I'm confused.  AFAIK, that commit did not change which "prove" would
>> be used --- at least not unless you change PATH between configure and
>> make.  It only changed how specifically that program would be named in
>> Makefile.global.  Please clarify how that broke anything.

> That's exactly what we do. See
> <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl> at
> line 1649.

My goodness, that's ugly.  Is it really better than injecting
"PROVE=prove"?  (I'd suggest saying that to configure, not make,
so that the configure log bears some resemblance to what you
want done.)

            regards, tom lane

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by"configure".
Next
From: Andrew Dunstan
Date:
Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by"configure".