Re: AW: AW: ALTER TABLE DROP COLUMN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: AW: AW: ALTER TABLE DROP COLUMN
Date
Msg-id 1022.971486111@sss.pgh.pa.us
Whole thread Raw
In response to Re: AW: AW: ALTER TABLE DROP COLUMN  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> This said, I think Hiroshi's patch seems a perfect starting point, no ?

> Having phantom columns adds additional complexity to the system overall.
> We have to decide we really want it before making things more complex
> than they already are.

I think we do, because it solves more than just the ALTER DROP COLUMN
problem: it cleans up other sore spots too.  Like ALTER TABLE ADD COLUMN
in a table with child tables.

Of course, it depends on just how ugly and intrusive the code changes
are to make physical and logical columns distinct.  I'd like to think
that some fairly limited changes in and around heap_getattr would do
most of the trick.  If we need something as messy as the first-cut
DROP_COLUMN_HACK then I'll look for another way...
        regards, tom lane


pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: AW: AW: AW: ALTER TABLE DROP COLUMN
Next
From: Philip Warner
Date:
Subject: Re: [GENERAL] Re: My new job