Re: Support building in a different directory on Solaris - Mailing list pgsql-patches

From Tom Lane
Subject Re: Support building in a different directory on Solaris
Date
Msg-id 10208.997478897@sss.pgh.pa.us
Whole thread Raw
In response to Support building in a different directory on Solaris  (Ian Lance Taylor <ian@airs.com>)
Responses Re: Support building in a different directory on Solaris  (Ian Lance Taylor <ian@airs.com>)
Re: Support building in a different directory on Solaris  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Ian Lance Taylor <ian@airs.com> writes:
> the test built in to /bin/sh does not support -ef, although
> /usr/bin/test does support it.

Rather than assuming a test with -ef is available, ISTM the portable
answer is not to depend on it at all.  Why not forget the whole thing
and use something like

  if [ `cd "$srcdir" ; /bin/pwd` = `/bin/pwd` ] ; then : ; else

> The second is that /bin/find requires
> an explicit -print when -o is used.

This is a good change.  A lot of older "find"s don't provide a default
-print action at all (-o or no -o), so writing -print is the portable
way to use it.  I don't think you need two of them though.

            regards, tom lane

pgsql-patches by date:

Previous
From: Ian Lance Taylor
Date:
Subject: Support building in a different directory on Solaris
Next
From: Ian Lance Taylor
Date:
Subject: Re: Support building in a different directory on Solaris