Re: Patch to add a primary key using an existing index - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to add a primary key using an existing index
Date
Msg-id 10207.1295892022@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to add a primary key using an existing index  (Steve Singer <ssinger_pg@sympatico.ca>)
Responses Re: Patch to add a primary key using an existing index  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Steve Singer <ssinger_pg@sympatico.ca> writes:
> src/backend/parser/parse_utilcmd.c: 1452
> Your calling strdup on the attribute name.  I don't have a good enough 
> grasp on the code to be able to trace this through to where the memory 
> gets free'd.  Does it get freed? Should/could this be a call to pstrdup

strdup() is pretty much automatically wrong in the parser, not to
mention most of the rest of the backend.  pstrdup is likely what was
meant.  If that's the only issue then I don't see any need to wait on
the author, so will take this one.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: wildcard search support for pg_trgm
Next
From: Magnus Hagander
Date:
Subject: Re: Allowing multiple concurrent base backups