Re: Parallel Aggregate - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parallel Aggregate
Date
Msg-id 10158.1457329140@sss.pgh.pa.us
Whole thread Raw
In response to Re: Parallel Aggregate  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: Parallel Aggregate
List pgsql-hackers
Haribabu Kommi <kommi.haribabu@gmail.com> writes:
> 2. Temporary fix for float aggregate types in _equalAggref because of
> a change in aggtype to trans type, otherwise the parallel aggregation
> plan failure in set_plan_references. whenever the aggtype is not matched,
> it verifies with the trans type also.

That is a completely unacceptable kluge.  Quite aside from being ugly as
sin, it probably breaks more things than it fixes, first because it breaks
the fundamental semantics of equal() across the board, and second because
it puts catalog lookups into equal(), which *will* cause problems.  You
can not expect that this will get committed, not even as a "temporary fix".
        regards, tom lane



pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: Parallel Aggregate
Next
From: Tom Lane
Date:
Subject: Re: WIP: Upper planner pathification