Re: Proposal: BSD Authentication support - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Proposal: BSD Authentication support
Date
Msg-id 10126.1460133370@sss.pgh.pa.us
Whole thread Raw
In response to Re: Proposal: BSD Authentication support  (David Steele <david@pgmasters.net>)
List pgsql-hackers
David Steele <david@pgmasters.net> writes:
> On 4/8/16 11:20 AM, Robert Haas wrote:
>> Should we commit this patch?

> To summarize:

> Robert Haas and Peter Eisentraut have done code-only reviews.  Thomas
> Munro has reviewed and tested with a caveat that he is no BSD expert.
> Pierre-Emmanuel tested but did not do a code review review due to his
> unfamiliarity with the Postgres code-base.

> The patch does not seem invasive or likely to cause problems on non-BSD
> systems.  From my perspective this has gotten about as much review as it
> can, so +1 from me at least.

Given our lack of BSD developers, there's probably not much more we can
do, but one more set of eyeballs on the patch wouldn't hurt.  I'll take
it, unless somebody else wants to.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Paul Ramsey
Date:
Subject: Re: Choosing parallel_degree
Next
From: Andres Freund
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics