Request a Demo
Home   >   mailing lists

Re: Enable -Wstrict-prototypes and -Wold-style-definition by default - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Date
Msg-id 1012008.1773862140@sss.pgh.pa.us
Whole thread Raw
In response to Re: Enable -Wstrict-prototypes and -Wold-style-definition by default  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Tree view 
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> On Wed, Mar 18, 2026 at 01:03:03PM -0400, Tom Lane wrote:
>> We could plausibly fix this either by
>> 
>> (1) renaming ecpg_init_sqlca's parameter to something else;
>> 
>> (2) ensuring that POSTGRES_ECPG_INTERNAL is defined.  I'd be inclined
>> to make ecpglib_extern.h do that rather than expecting headerscheck
>> to know about it.
>> 
>> Neither of these options are beautiful, but perhaps #1 is slightly
>> less ugly.  Any preferences?

> I'd vote for #1 too, done in the attached.

Agreed and pushed.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error
Next
From: Robert Haas
Date:
Subject: Re: Better shared data structure management and resizable shared data structures