Re: More time spending with "delete pending" - Mailing list pgsql-hackers

Alexander Lakhin <exclusion@gmail.com> writes:
> 18.11.2020 23:39, Tom Lane wrote:
>> Now, the ones on the 10 and 11 branches are all from pg_ctl, which
>> does not use pgwin32_open() in those branches, only native open().
>> So those aren't fair to count against it.  But we have nearly as
>> many similar failures in HEAD, which surely is going through
>> pgwin32_open().  So either we don't really have adequate protection
>> against delete-pending files, or there is some other effect we haven't
>> explained yet.

> Can you confirm that there are no such failures on REL_12_STABLE and
> REL_13_STABLE for last three (or maybe six) months? Maybe something
> changed in HEAD then?

Hmm, that is an interesting question isn't it.  Here's a search going
back a full year.  There are a few in v12 --- interestingly, all on
the statistics file, none from pg_ctl --- and none in v13.  Of course,
v13 has only existed as a separate branch since 2020-06-07.

There's also a buildfarm test-coverage artifact involved.  The bulk
of the HEAD reports are from dory and walleye, neither of which are
building v13 as yet, because of unclear problems [1].  I think those
two animals build much more frequently than our other Windows animals,
too, so the fact that they have more may be just because of that and
not because they're somehow more susceptible.  Because of that, I'm not
sure that we have enough evidence to say that v13 is better than HEAD.
If there is some new bug, it's post-v12, but maybe not post-v13.  But
v12 is evidently not perfect either.

            regards, tom lane

[1] https://www.postgresql.org/message-id/flat/CA%2BBEBhvHhM-Bn628pf-LsjqRh3Ang7qCSBG0Ga%2B7KwhGqrNUPw%40mail.gmail.com

 dory         | HEAD          | 2019-11-20 19:40:33 | Check                               | pg_ctl: could not open PID
file"c:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 dory         | HEAD          | 2019-11-21 01:25:40 | Check                               | pg_ctl: could not open PID
file"c:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 fairywren    | REL_11_STABLE | 2019-11-24 01:34:33 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/tools/msys64/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/recovery/tmp_check/t_007_sync_rep_standby2_data/pgdata/postmaster.pid":
Permissiondenied\r 
 fairywren    | REL_11_STABLE | 2019-12-04 13:14:03 | StopDb-C:4                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 fairywren    | REL_11_STABLE | 2019-12-06 15:03:10 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/tools/msys64/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/recovery/tmp_check/t_003_recovery_targets_standby_9_data/pgdata/postmaster.pid":
Permissiondenied\r 
 dory         | HEAD          | 2019-12-09 03:50:32 | pg_upgradeCheck                     | waiting for server to shut
down..............pg_ctl:could not open PID file
"c:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/data.old/postmaster.pid":Permission denied\r 
 dory         | HEAD          | 2019-12-11 07:45:33 | Check                               | pg_ctl: could not open PID
file"c:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 woodlouse    | HEAD          | 2019-12-14 07:42:41 | StopDb-C:1                          | waiting for server to shut
down......pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 lorikeet     | REL_12_STABLE | 2019-12-27 11:50:56 | Check                               | 2019-12-27 06:57:31.645 EST
[5e05f1a9.5904:277]pg_regress/vacuum WARNING:  could not open statistics file
"/cygdrive/w/lorikeet/REL_12_STABLE/global.stat":Permission denied 
 bowerbird    | REL_11_STABLE | 2019-12-27 22:23:56 | StopDb-C:1                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 drongo       | REL_11_STABLE | 2019-12-28 08:30:21 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/prog/bf/root/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data/postmaster.pid":Permission denied\r 
 hamerkop     | REL_11_STABLE | 2020-01-22 11:49:18 | StopDb-C:3                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 jacana       | REL_11_STABLE | 2020-02-10 04:59:45 | module-test_pg_dumpCheck            | Feb 10 01:01:11 pg_ctl:
couldnot open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/modules/test_pg_dump/./tmp_check/data/postmaster.pid":
Permissiondenied\r 
 fairywren    | REL_11_STABLE | 2020-02-10 12:59:57 | StopDb-C:2                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 fairywren    | REL_11_STABLE | 2020-02-19 09:59:59 | Check                               | pg_ctl: could not open PID
file"C:/tools/msys64/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid":
Permissiondenied\r 
 hamerkop     | REL_11_STABLE | 2020-03-10 11:52:00 | StopDb-C:3                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 dory         | HEAD          | 2020-03-13 13:30:34 | Check                               | pg_ctl: could not open PID
file"c:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 whelk        | REL_11_STABLE | 2020-03-13 14:41:30 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/buildfarm/buildenv/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data/postmaster.pid":Permission denied\r 
 currawong    | REL_10_STABLE | 2020-03-17 04:30:09 | StopDb-C:4                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 jacana       | REL_10_STABLE | 2020-03-18 15:58:46 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_10_STABLE/pgsql.build/src/test/recovery/tmp_check/data_standby_1_xeWT/pgdata/postmaster.pid":
Permissiondenied\r 
 lorikeet     | HEAD          | 2020-03-20 00:20:47 | Check                               | 2020-03-19 20:46:11.115 EDT
[5e741250.3320:287]pg_regress/create_index WARNING:  could not open statistics file
"/cygdrive/w/lorikeet/HEAD/global.stat":Permission denied 
 jacana       | REL_11_STABLE | 2020-03-21 04:14:53 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/recovery/tmp_check/t_004_timeline_switch_standby_1_data/pgdata/postmaster.pid":
Permissiondenied\r 
 currawong    | REL_10_STABLE | 2020-03-26 16:30:09 | StopDb-C:5                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 jacana       | REL_10_STABLE | 2020-04-06 18:56:17 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_10_STABLE/pgsql.build/src/test/recovery/tmp_check/data_master_yKQT/pgdata/postmaster.pid":
Permissiondenied\r 
 bowerbird    | REL_11_STABLE | 2020-04-08 12:04:10 | StopDb-C:2                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 hamerkop     | REL_10_STABLE | 2020-04-20 12:16:39 | StopDb-C:1                          | waiting for server to shut
down.....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 jacana       | REL_11_STABLE | 2020-05-08 12:01:21 | pgbenchCheck                        | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/bin/pgbench/tmp_check/t_001_pgbench_with_server_main_data/pgdata/postmaster.pid":
Permissiondenied\r 
 whelk        | REL_11_STABLE | 2020-05-18 05:41:33 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/buildfarm/buildenv/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data.old/postmaster.pid":Permission
denied\r
 jacana       | REL_11_STABLE | 2020-05-18 13:01:01 | pg_dumpCheck                        | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/bin/pg_dump/tmp_check/t_002_pg_dump_main_data/pgdata/postmaster.pid":
Permissiondenied\r 
 whelk        | REL_11_STABLE | 2020-06-01 07:41:32 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/buildfarm/buildenv/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data/postmaster.pid":Permission denied\r 
 lorikeet     | REL_12_STABLE | 2020-06-04 03:51:45 | Check                               | 2020-06-03 23:57:52.099 EDT
[5ed8713f.40c:280]pg_regress/vacuum WARNING:  could not open statistics file
"/cygdrive/w/lorikeet/REL_12_STABLE/global.stat":Permission denied 
 lorikeet     | HEAD          | 2020-06-10 09:53:57 | Check                               | 2020-06-10 06:02:01.254 EDT
[5ee0af98.3bd0:78]pg_regress/vacuum WARNING:  could not open statistics file "/cygdrive/w/lorikeet/HEAD/global.stat":
Permissiondenied 
 dory         | REL_10_STABLE | 2020-06-12 01:30:03 | StopDb-C:2                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 hamerkop     | REL_10_STABLE | 2020-06-12 12:11:19 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/build-farm-local/buildroot/REL_10_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data/postmaster.pid":Permission
denied\r
 hamerkop     | REL_10_STABLE | 2020-06-16 12:07:27 | StopDb-C:3                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 dory         | REL_11_STABLE | 2020-07-16 10:15:06 | StopDb-C:1                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 dory         | HEAD          | 2020-07-25 20:35:06 | StopDb-C:1                          | waiting for server to shut
down.....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 bowerbird    | REL_10_STABLE | 2020-08-11 11:27:11 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"H:/prog/bf/root/REL_10_STABLE/pgsql.build/src/test/recovery/tmp_check/data_paris_2TSi/pgdata/postmaster.pid":
Permissiondenied\r 
 lorikeet     | REL_12_STABLE | 2020-08-17 08:28:25 | InstallCheck-C                      | 2020-08-17 04:38:51.519 EDT
[5f3a4218.1e74:643]pg_regress/create_index WARNING:  could not open statistics file
"/cygdrive/w/lorikeet/REL_12_STABLE/global.stat":Permission denied 
 jacana       | REL_10_STABLE | 2020-08-18 00:44:51 | pg_upgradeCheck                     | Aug 17 21:13:05 waiting for
serverto shut down....pg_ctl: could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_10_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data.old/postmaster.pid":
Permissiondenied\r 
 dory         | REL_11_STABLE | 2020-08-21 22:15:14 | Check                               | pg_ctl: could not open PID
file"C:/pgbuildfarm/pgbuildroot/REL_11_STABLE/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission
denied\r
 fairywren    | REL_11_STABLE | 2020-09-01 01:04:55 | Check                               | pg_ctl: could not open PID
file"C:/tools/msys64/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid":
Permissiondenied\r 
 dory         | HEAD          | 2020-09-16 02:40:17 | Check                               | pg_ctl: could not open PID
file"C:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 walleye      | HEAD          | 2020-09-29 18:35:46 | pg_upgradeCheck                     | 2020-09-29 15:20:04.298 EDT
[896:31]pg_regress/gist WARNING:  could not open statistics file "pg_stat_tmp/global.stat": Permission denied 
 frogmouth    | REL_10_STABLE | 2020-10-01 00:30:15 | StopDb-C:5                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 dory         | REL_11_STABLE | 2020-10-05 02:15:06 | pg_upgradeCheck                     | waiting for server to shut
down..............pg_ctl:could not open PID file
"C:/pgbuildfarm/pgbuildroot/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data.old/postmaster.pid":Permission
denied\r
 bowerbird    | REL_10_STABLE | 2020-10-21 23:19:22 | scriptsCheck                        | waiting for server to shut
down....pg_ctl:could not open PID file
"H:/prog/bf/root/REL_10_STABLE/pgsql.build/src/bin/scripts/tmp_check/data_main_cH68/pgdata/postmaster.pid":Permission
denied\r
 jacana       | REL_10_STABLE | 2020-10-22 12:42:51 | pg_upgradeCheck                     | Oct 22 09:08:20 waiting for
serverto shut down....pg_ctl: could not open PID file
"c:/mingw/msys/1.0/home/pgrunner/bf/root/REL_10_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data.old/postmaster.pid":
Permissiondenied\r 
 dory         | HEAD          | 2020-10-22 23:30:16 | Check                               | pg_ctl: could not open PID
file"C:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 dory         | REL_11_STABLE | 2020-10-27 18:15:08 | StopDb-C:2                          | waiting for server to shut
down....pg_ctl:could not open PID file "data-C/postmaster.pid": Permission denied\r 
 fairywren    | REL_11_STABLE | 2020-10-28 04:01:17 | recoveryCheck                       | waiting for server to shut
down....pg_ctl:could not open PID file
"C:/tools/msys64/home/pgrunner/bf/root/REL_11_STABLE/pgsql.build/src/test/recovery/tmp_check/t_004_timeline_switch_standby_2_data/pgdata/postmaster.pid":
Permissiondenied\r 
 hamerkop     | REL_11_STABLE | 2020-11-01 11:31:54 | pg_upgradeCheck                     | waiting for server to shut
down....pg_ctl:could not open PID file
"c:/build-farm-local/buildroot/REL_11_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/data/postmaster.pid":Permission
denied\r
 dory         | HEAD          | 2020-11-04 05:50:17 | Check                               | pg_ctl: could not open PID
file"C:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r 
 walleye      | HEAD          | 2020-11-09 09:45:41 | Check                               | 2020-11-09 05:06:19.672 EST
[4408:31]pg_regress/gist WARNING:  could not open statistics file "pg_stat_tmp/global.stat": Permission denied 
 dory         | HEAD          | 2020-11-10 23:35:18 | Check                               | pg_ctl: could not open PID
file"C:/pgbuildfarm/pgbuildroot/HEAD/pgsql.build/src/test/regress/./tmp_check/data/postmaster.pid": Permission denied\r