On Thu, 2001-10-11 at 04:54, Tom Lane wrote:
> Sounds like a great idea --- the ALTER TABLE code has kind of grown
> without supervision over the past few releases, since cut-and-paste
> was the easiest starting point for implementing any new variant.
> Some creative refactoring would help it out a lot. Go for it, if
> you feel like doing that.
>
I've done a little tidying, repackaging of standard code etc. as a first
step. It hasn't made the file much shorter, but has made some of the
routines clearer where they share basically the same code for
inheritance and permissions checking.
AS regards the ALTER TABLE ALTER COLUMN syntax for attstorage, should I
use keywords for the values or just char values 'e', 'x' etc ?
ALTER TABLE example ALTER COLUMN test SET STORAGE EXTERNALPLAIN;
or
ALTER TABLE example ALTER COLUMN test SET STORAGE 'e';
(if anyone has any views on a better keyword than STORAGE...)
Obviously I'll have to get to grips with the parser next (which will be
a novelty as I don't have any familiarity with lex/yacc)
Regards
John
