Magnus Hagander <magnus@hagander.net> writes:
> The attached patch changes pg_settings.enumval to be an array of text
> instead of just a string, per previous discussion and the open items list.
> Comments?
Hmmm ... this coding will fail if any enumval contains a double quote.
Which is probably not a big problem, but we ought to document the
restriction somewhere.
Also, this:
> ! if (len > strlen(separator)-1)
> ! /* Replace final separator */
> ! hintmsg[len-strlen(separator)] = '\0';
would read better IMHO as "if (len >= strlen(separator))".
Also, the output datatype should be text[] not cstring[].
Otherwise seems okay.
regards, tom lane
