Re: [PATCH] postmaster: fix stale PM_STARTUP comment - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [PATCH] postmaster: fix stale PM_STARTUP comment
Date
Msg-id 0f462532-9790-4334-b503-4ee522225820@iki.fi
Whole thread
In response to [PATCH] postmaster: fix stale PM_STARTUP comment  (Ayush Tiwari <ayushtiwari.slg01@gmail.com>)
Responses Re: [PATCH] postmaster: fix stale PM_STARTUP comment
List pgsql-hackers
On 15/04/2026 16:57, Ayush Tiwari wrote:
> Hi,
> 
> The comment above the PM_STARTUP startup-process-failure case still says
> that there are no other processes running yet, so the postmaster can just
> exit.
> 
> That no longer matches the current startup flow: PM_STARTUP may already
> have auxiliary processes running by that point. The attached patch updates
> that comment to describe the current behavior.

Hmm, shouldn't the postmaster kill and wait for the auxiliary processes 
to exit first in that case? ISTM we need code changes here, not just 
comments.

- Heikki




pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Add errdetail() with PID and UID about source of termination signal
Next
From: Bruce Momjian
Date:
Subject: Re: First draft of PG 19 release notes