Re: Redefining inet_net_ntop - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Redefining inet_net_ntop
Date
Msg-id 0c5db733-cbea-bf6b-1d3c-46db325e8612@2ndquadrant.com
Whole thread Raw
In response to Redefining inet_net_ntop  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On 1/25/18 22:24, Craig Ringer wrote:
> port.h declares inet_net_ntop and we always compile our own
> from port/inet_net_ntop.c .
> 
> But it's part of -lresolv on Linux, and more importantly, it's declared
> in <inet/arpa.h>.
> 
> Should we be using our own if the OS has it? I'm thinking of adding a
> test to configure and omitting our own version if configure finds it.

ISTR that ours is hacked to produce specific output.  Do the regression
tests still pass if you use the one from the OS?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: WIP: Covering + unique indexes.
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Temporary tables prevent autovacuum, leading to XID wraparound