Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py - Mailing list pgsql-www

From Célestin Matte
Subject Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Date
Msg-id 0c0f0cff-513a-e2e5-8ff7-a8f1463e364d@cmatte.me
Whole thread Raw
In response to Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py  (Magnus Hagander <magnus@hagander.net>)
List pgsql-www
Tree view 
Hi,

I'm reviewing the patches I sent a few months ago and this short one seems to have been left mid-discussion.

> I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the
samename as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need
toadd code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :)
 

I guess it's OK as-is, then?

-- 
Célestin Matte

pgsql-www by date:

Previous
From: Célestin Matte
Date:
Subject: Re: [PATCH] pglister: Add example script to import from mailman
Next
From: Magnus Hagander
Date:
Subject: Re: [PATCH] Fix typo in an unsubscribe-related message