Re: Announcing Release 6 of PostgreSQL Buildfarm client - Mailing list buildfarm-members

From Andrew Dunstan
Subject Re: Announcing Release 6 of PostgreSQL Buildfarm client
Date
Msg-id 0b3217e4-b275-ba4d-0571-30b4aae237e0@2ndQuadrant.com
Whole thread Raw
In response to Re: Announcing Release 6 of PostgreSQL Buildfarm client  (Tom Lane <tgl@sss.pgh.pa.us>)
List buildfarm-members

On 01/04/2018 12:51 PM, Tom Lane wrote:
> I wrote:
>> which means I get mail every time the cron script runs.  Needless
>> to say, that will not do.  Previously, mail only showed up when
>> there was a git checkout failure.  How do I get back to the
>> old behavior?
> Diff'ing the v5 and v6 releases soon provided the answer: for some
> reason v6 is forcing the verbose switch on.  I hope that was
> unintentional?  Anyway, I'm happy again after applying this patch:
>
> --- PGBuild/Options.pm~ 2018-01-04 08:38:29.000000000 -0500
> +++ PGBuild/Options.pm  2018-01-04 12:40:14.000000000 -0500
> @@ -78,8 +78,6 @@
>      GetOptions(%standard_options, @_)
>        || die "bad command line";
>  
> -    # override GetOptions default for :i
> -    $verbose = 1 if (defined($verbose) && $verbose==0);
>      $verbose ||= 0; # stop complaints about undefined var in numeric comparison
>  }
>  



This should fix it:

<https://raw.githubusercontent.com/PGBuildFarm/client-code/5c71fb6ba1be83db6aca45e718b4a541b0b89f4c/PGBuild/Options.pm>

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



buildfarm-members by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Announcing Release 6 of PostgreSQL Buildfarm client
Next
From: Tom Lane
Date:
Subject: We have no Windows critters contributing typedef lists