Re: ObjectIdGetDatum() missing from SearchSysCache*() callers - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: ObjectIdGetDatum() missing from SearchSysCache*() callers
Date
Msg-id 0a6ee217-6958-4f13-9af8-61904f677f09@Spark
Whole thread Raw
In response to ObjectIdGetDatum() missing from SearchSysCache*() callers  (Michael Paquier <michael@paquier.xyz>)
Responses Re: ObjectIdGetDatum() missing from SearchSysCache*() callers
List pgsql-hackers
Hi

Regards,
Zhang Mingli
On Jul 17, 2023 at 19:10 +0800, Michael Paquier <michael@paquier.xyz>, wrote:
Hi all,

While scanning the code, I have noticed that a couple of code paths
that do syscache lookups are passing down directly Oids rather than
Datums. I think that we'd better be consistent here, even if there is
no actual bug.

I have noticed 11 callers of SearchSysCache*() that pass down
an Oid instead of a Datum.

Thoughts or comments?
--
Michael
LGTM, and there are two functions missed, in sequence_options

 pgstuple = SearchSysCache1(SEQRELID, relid);

Shall we fix that too?

pgsql-hackers by date:

Previous
From: Jelte Fennema
Date:
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Next
From: Zhang Mingli
Date:
Subject: Re: ObjectIdGetDatum() missing from SearchSysCache*() callers