Fix typos and inconsistencies for v11+ - Mailing list pgsql-hackers
From | Alexander Lakhin |
---|---|
Subject | Fix typos and inconsistencies for v11+ |
Date | |
Msg-id | 0a5419ea-1452-a4e6-72ff-545b1a5a8076@gmail.com Whole thread Raw |
Responses |
Re: Fix typos and inconsistencies for v11+
|
List | pgsql-hackers |
Hello hackers, Please consider fixing the following typos and inconsistencies living in the source code starting from v11: 3.1 add_placeholders_to_child_joinrel -> remove (orphaned after 7cfdc770) 3.2 AttachIndexInfo -> IndexAttachInfo (an internal inconsistency) 3.3 BlockRecordInfo -> BlockInfoRecord (an internal inconsistency) 3.4 bount -> bound (a typo) 3.5 CopyBoth -> CopyBothResponse (an internal inconsistency) 3.6 directy -> directory (a typo) 3.7 ExecCreateSlotFromOuterPlan -> ExecCreateScanSlotFromOuterPlan (an internal inconsistency) 3.8 es_epqTuple -> es_epqTupleSlot (an internal inconsistency) 3.9 ExecHashTableParallelInsert -> ExecParallelHashTableInsert (an internal inconsistency) 3.10 ExecMakeFunctionResult -> ExecMakeFunctionResultSet (an internal inconsistency) 3.11 fmgr_builtins_oid_index -> fmgr_builtin_oid_index (an internal inconsistency) 3.12 freeScanStack -> remove (irrelevant after 2a636834, v12 only) 3.13 GetTupleTrigger -> GetTupleForTrigger (an internal inconsistency) 3.14 grow_barrier -> grow_batches_barrier (an internal inconsistency) 3.15 HAVE__BUIILTIN_CLZ -> HAVE__BUILTIN_CLZ (a typo, v12 only) 3.16 ignored_killed_tuples -> ignore_killed_tuples (a typo) 3.17 intset_tests_stats -> intset_test_stats (an internal inconsistency, v12 only) 3.18 is_aggregate -> objtype (needed to determine error handling and required result type) (an internal inconsistency) 3.19 iterate_json_string_values -> iterate_json_values (renamed in 1c1791e0) 3.20 $log_number -> remove (not used since introduction in ed8a7c6f) 3.21 mechinism -> mechanism (a typo) 3.22 new_node, new_node_item -> child, child_key (an internal inconsistency, v12 only) 3.23 new_part_constaints -> new_part_constraints (a typo) 3.24 parentIndexOid -> parentIndexId (for the sake of consistency, but this argument is still unused since 8b08f7d4) 3.25 particiant -> participant (a typo) 3.26 PathNameCreateShared -> SharedFileSetCreate (an internal inconsistency) 3.27 PathnameCreateTemporaryDir -> PathNameCreateTemporaryDir (an inconsistent case) 3.28 pg_access_server_files -> pg_read_server_files or pg_write_server_files (non-existing role referenced) 3.29 pg_beginmessage_reuse -> pq_beginmessage_reuse (a typo) 3.30 Form_pg_fdw & pg_fdw -> Form_pg_foreign_data_wrapper & pg_foreign_data_wrapper (an internal inconsistency) 3.31 PG_MCV_LIST -> pg_mcv_list (an internal inconsistency, v12 only) 3.32 pg_partition_table -> pg_partitioned_table (an internal inconsistency) 3.33 pg_write -> pg_pwrite (an internal inconsistency, v12 only) 3.34 PLyObject_FromJsonb -> PLyObject_FromJsonbContainer (an internal inconsistency) 3.35 port_win32.h -> win32_port.h (an internal inconsistency) 3.36 PruneCtxStateIdx -> PruneCxtStateIdx (an internal inconsistency) 3.37 SetErrormode -> SetErrorMode (an internal inconsistency) 3.38 SharedRecordTypemodRegistry -> SharedRecordTypmodRegistry (an internal inconsistency) 3.39 SharedTupleStore -> SharedTuplestore (an internal inconsistency) 3.40 shm_mq_get_receive_bytes -> shm_mq_receive_bytes (an internal inconsistency) 3.41 t_natts -> number-of-attributes (questionable) (renamed in storage.sgml with 3e23b68d, but one reference is left) 3.42 tts_buffer -> remove (orphaned after 4da597ed, v12 only) 3.43 tts_flag -> tts_flags (an internal inconsistency, v12 only) 3.44 tts_off -> remove (orphaned after 4da597ed, v12 only) 3.45 _vaues -> _values (a typo) 3.46 wait_event_class -> wait_event_type (an internal inconsistency) 3.47 WarnNoTranactionBlock -> WarnNoTransactionBlock (a typo) 3.48 with-wal-segsize -> remove (orphaned after fc49e24f) 3.49 XLOG_SEG_SIZE -> WAL segment size (orphaned after fc49e24fa) Two summary patches for REL_11_STABLE and master are attached. Best regards, Alexander
Attachment
pgsql-hackers by date: