Request a Demo
Home   >   mailing lists

Re: Remaining dependency on setlocale() - Mailing list pgsql-hackers

From Chao Li
Subject Re: Remaining dependency on setlocale()
Date
Msg-id 0E8DD47F-710D-45E1-B87F-2336042A377E@gmail.com
Whole thread Raw
In response to Re: Remaining dependency on setlocale()  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
Tree view 

> On Dec 13, 2025, at 04:11, Jeff Davis <pgsql@j-davis.com> wrote:
>
> I believe v12 0001-0005 are about ready for commit, and 0003 should be
> backported.

I quickly went through 0001-0005, and got a few nitpicks:

1 - 0001
```
+    int            match_mblen pg_attribute_unused();
```

Why this variable is marked unused? It’s actually used.

2 - 0002

I did a search and found one place that you missed at line 181 in pg_locale.h
```
extern bool char_is_cased(char ch, pg_locale_t locale);
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: Support named (destination) portals in extended proto for psql meta commands.