Re: Error message against iso-8859-1 key in pg_service.conf is unclear - Mailing list pgsql-hackers

From Chao Li
Subject Re: Error message against iso-8859-1 key in pg_service.conf is unclear
Date
Msg-id 0C613D16-6C8B-4CD4-9B47-70736489C290@gmail.com
Whole thread Raw
In response to Re: Error message against iso-8859-1 key in pg_service.conf is unclear  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers

> On Oct 17, 2025, at 00:27, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>
> On Wed, Oct 15, 2025 at 7:30 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> The error message showed the correct line number, but “syntax error” is confusing. Shouldn’t it be something like
“invalidconfiguration parameter: default”? 
>
> I think so; see patch 0003 in [1].
>
> --Jacob
>
> [1] https://postgr.es/m/CAOYmi%2BkYKPXCfiAF3xAu%2BcHYSLYEc4OC9Wsh2nebwWboNbkpeQ%40mail.gmail.com

Cool! So, patch 0003 should more likely belong to this discussion. :)

I reviewed and tested 0003. But I failed to “git am” it, maybe need a rebase. So I manually applied the change to my
local.

The change looks good to me. And the new TAP test also passed in my side. I think we can push this patch separately.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: John H
Date:
Subject: Re: Making pg_rewind faster
Next
From: Michael Paquier
Date:
Subject: Re: [BUG] temporary file usage report with extended protocol and unnamed portals