Re: Serverside SNI support in libpq - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Serverside SNI support in libpq
Date
Msg-id 0C53C316-C24E-4307-807B-D825CA3F7254@yesql.se
Whole thread Raw
In response to Re: Serverside SNI support in libpq  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: Serverside SNI support in libpq
List pgsql-hackers
> On 12 Nov 2025, at 23:44, Jacob Champion <jacob.champion@enterprisedb.com> wrote:

> Did you have any thoughts on my earlier review [2]? The test patch
> attached there still fails on my machine with v9.

The attached incorporates your tests, fixes them to make them pass.  The
culprit seemed to be a combination of a bug in the code (the verify callback
need to be defined in the default context even if there is no CA for it to be
called in an SNI setting because OpenSSL), and that the tests were matching
backend errors against frontend messages.

The other comments from your review are also addressed, as well as additional
cleanup and improved error handling.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: refactor AlterDomainAddConstraint (alter domain add constraint)
Next
From: Bertrand Drouvot
Date:
Subject: Re: get rid of Pointer type, mostly