Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly - Mailing list pgsql-hackers

From Tsunakawa, Takayuki
Subject Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly
Date
Msg-id 0A3221C70F24FB45833433255569204D1F640402@G01JPEXMBYT05
Whole thread Raw
In response to Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Robert Haas
> Let me try to be more clear.  I will not commit this patch if it is not
> properly commented.  I doubt that anyone else will, either.
> 
> The fact that those code changes already exist in 9.4+ is not a reason to
> back-port them to earlier releases without a proper explanation of why we
> are doing it.  Very possibly, we should also improve the comments in newer
> branches so that future authors don't reintroduce whatever bugs were fixed
> by these changes.  But whether we do that or not, I am not going to commit
> uncommented patches to complex code in order to fix obscure bugs in
> 3+-year-old branches.  I think that is a non-starter.
> 

OK, although I'm not perfectly sure what to add as a comment, I added an example scenario as a comment because I
thoughta concrete situation helps to understand the existing two paragraphs.  Is this good?
 

Regards
Takayuki Tsunakawa


Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Adding the optional clause 'AS' in CREATE TRIGGER
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Fix checkpoint skip logic on idle systems by tracking LSN progress