Re: document pg_settings view doesn't display custom options - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: document pg_settings view doesn't display custom options
Date
Msg-id 09b4b914-7fcf-b337-b3cd-55569cf24a48@oss.nttdata.com
Whole thread Raw
In response to Re: document pg_settings view doesn't display custom options  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: document pg_settings view doesn't display custom options  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers

On 2020/11/07 0:42, Fujii Masao wrote:
> 
> 
> On 2020/10/31 2:06, John Naylor wrote:
>>
>>
>> On Fri, Oct 30, 2020 at 12:48 PM Tom Lane <tgl@sss.pgh.pa.us <mailto:tgl@sss.pgh.pa.us>> wrote:
>>
>>     John Naylor <john.naylor@enterprisedb.com <mailto:john.naylor@enterprisedb.com>> writes:
>>      > Okay, along those lines here's a patch using "this view" in a new paragraph
>>      > for simplicity.
>>
>>     Basically OK with me, but ...
>>
>>     <quibble>
>>     It seems fairly weird to use a nonspecific reference first and then a
>>     specific one.  That is, I'd expect to read "The pg_settings view ..."
>>     and then "This view ...", not the other way around.  So we could
>>     put this para second, or put it first but make this para say
>>     "The pg_settings view ..." while the existing text gets reduced to
>>     "This view ...".
>>
>>     Or just make them both say "This view ..." so we don't have to have
>>     this discussion again the next time somebody wants to add a para here.
>>     </quibble>
>>
>>
>> Okay, how's this?
> 
> Looks good to me. Barring any objection, I will commit the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: abstract Unix-domain sockets
Next
From: Greg Stark
Date:
Subject: Re: Temporary tables versus wraparound... again