Re: [PATCH] Add error_on_null() to produce an error if the input is null - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: [PATCH] Add error_on_null() to produce an error if the input is null
Date
Msg-id 088852ea-9c24-46f4-9981-9d961f226500@postgresfriends.org
Whole thread Raw
In response to [PATCH] Add error_on_null() to produce an error if the input is null  ("Joel Jacobson" <joel@compiler.org>)
Responses Re: [PATCH] Add error_on_null() to produce an error if the input is null
List pgsql-hackers
On 30/08/2025 13:49, Joel Jacobson wrote:
> Dear fellow hackers,
>
> This polymorphic function produces an error if the input value is null,
> otherwise it returns the input value unchanged.


This only checks for the null value.  I don't think we need to change 
the function's name, but we do need to be more precise in the 
documentation that it checks for the null value and not values that are 
null.


Perhaps replacing "Produces an error if the input is null, and returns 
the input otherwise." with "Produces an error if the input is the null 
value, and returns the input otherwise."


Then also add ROW(NULL, NULL)) to the regressions tests showing that we 
are aware that that is the behavior for things that are null but are not 
the null value.

-- 

Vik Fearing




pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: [PATCH] Add error_on_null() to produce an error if the input is null
Next
From: Alexander Lakhin
Date:
Subject: Re: Correction of RowMark Removal During Sel-Join Elimination