Re: add missing errdetail for xlogreader allocation failure error - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: add missing errdetail for xlogreader allocation failure error
Date
Msg-id 079D519B-0FA2-40DB-B373-8B58D52B69D9@yesql.se
Whole thread Raw
In response to add missing errdetail for xlogreader allocation failure error  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: add missing errdetail for xlogreader allocation failure error
List pgsql-hackers
> On 19 Nov 2021, at 04:59, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

> It seems like some of the XLogReaderAllocate failure check errors are
> not having errdetail "Failed while allocating a WAL reading
> processor." but just the errmsg "out of memory". The "out of memory"
> message without the errdetail is too generic and let's add it for
> consistency and readability of the message in the server logs.
>
> Here's a tiny patch. Thoughts?

No objections.  There are quite a few more "out of memory" errors without
errdetail but that doesn't mean we can't move the needle with these.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: rename SnapBuild* macros in slot.c
Next
From: Julien Rouhaud
Date:
Subject: Re: add missing errdetail for xlogreader allocation failure error