Re: Review for GetWALAvailability() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Review for GetWALAvailability()
Date
Msg-id 06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com
Whole thread Raw
In response to Re: Review for GetWALAvailability()  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers

On 2020/06/18 3:04, Alvaro Herrera wrote:
> I think passing the slot name when the slot is also passed is useless
> and wasteful; it'd be better to pass NULL for the name and ignore the
> strcmp() in that case -- in fact I suggest to forbid passing both name
> and slot.  (Any failure there would risk raising an error during
> checkpoint, which is undesirable.)

Sounds reasonable.

> So I propose the following tweaks to your patch, and otherwise +1.

Thanks for the patch! It looks good to me.

Barring any objections, I will commit the patches in the master and
v13 branches later.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Improve planner cost estimations for alternative subplans
Next
From: Michael Paquier
Date:
Subject: Re: pg_regress cleans up tablespace twice.