Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag - Mailing list pgsql-hackers

Hi,

On 10/5/23 6:23 PM, Bharath Rupireddy wrote:
> On Thu, Oct 5, 2023 at 9:32 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> +  CREATE ROLE nologrole with nologin;
>> +  GRANT CREATE ON DATABASE mydb TO nologrole;
> 
> A few nit-picks:
> 
> 1. s/with/WITH
> 2. s/nologin/NOLOGIN

done in v8 attached.

> 3. +   is specified as <varname>flags</varname> it is possible to
> bypass the login check to connect to databases.
> How about "it is possible to bypass the login check for the role used
> to connect to databases."?
> 

"for the role used" sounds implicit to me but I don't have a strong opinion
about it so re-worded as per your proposal in v8.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com