Re: CI: Add task that runs pgindent - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: CI: Add task that runs pgindent
Date
Msg-id 05e7413c-9201-4461-af89-f945239d6fe5@eisentraut.org
Whole thread Raw
In response to CI: Add task that runs pgindent  ("Jelte Fennema-Nio" <me@jeltef.nl>)
List pgsql-hackers
On 21.10.25 14:19, Jelte Fennema-Nio wrote:
> At PGConf.dev 2025 one thing that came up in the "Scaling PostgreSQL
> Development" unconference session is that new hackers don't know all the
> details of our development flow by heart yet. Of course it's documented
> on the wiki, but even if they find the relevant wiki pages they often
> still miss/forget things. One of the things they often forget is
> formatting their code. The consensus at that session was that it was
> probably worth adding a CI task for this to nudge newcomers to indent
> their code.

Good idea.

Additional suggestions:

Maybe there is a way to cache the pg_bsd_indent build.  In my testing, 
the configure and build steps each take 1/3 of the build time.  Could be 
worth it.

Also run the git whitespace check:

git diff-tree --check `git hash-object -t tree /dev/null` HEAD



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH v4] parallel pg_restore: avoid disk seeks when jumping short distance forward
Next
From: Philip Alger
Date:
Subject: Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement