Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken - Mailing list pgadmin-hackers

From pgAdmin Trac
Subject Re: [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken
Date
Msg-id 054.4c4b6336a51483e162bd6f93be883ad1@code.pgadmin.org
Whole thread Raw
In response to [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken  ("pgAdmin Trac" <trac@code.pgadmin.org>)
List pgadmin-hackers
Tree view 
#332: SQL for TRIGGER with WHEN clause broken
----------------------+-----------------------------------------------------
 Reporter:  brsa      |       Owner:  dpage
     Type:  patch     |      Status:  new  
 Priority:  minor     |   Milestone:       
Component:  pgadmin   |     Version:  trunk
 Keywords:  SQL pane  |    Platform:  all  
----------------------+-----------------------------------------------------
Changes (by brsa):

  * type:  bug => patch


Comment:

 The fix is pretty obvious in this case. The code mistakenly trims all
 outer enclosing brackets, which leads to unmatched brackets in test 2.) -
 both left brackets were removed.

 pgTrigger.cpp, line 393:

 - wxT("  trim(substring(pg_get_triggerdef(t.oid), 'WHEN (.*) EXECUTE
 PROCEDURE'), '()') AS whenclause\n")
 + wxT("  substring(pg_get_triggerdef(t.oid), 'WHEN (.*) EXECUTE
 PROCEDURE') AS whenclause\n")

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/332#comment:1>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

pgadmin-hackers by date:

Previous
From: "pgAdmin Trac"
Date:
Subject: [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken
Next
From: Guillaume Lelarge
Date:
Subject: Re: Weird git messages