Re: Question about InvalidatePossiblyObsoleteSlot() - Mailing list pgsql-hackers

From suyu.cmj
Subject Re: Question about InvalidatePossiblyObsoleteSlot()
Date
Msg-id 043df53e-6f11-4d6c-a178-04f4f8b2e742.mengjuan.cmj@alibaba-inc.com
Whole thread Raw
In response to Re: Question about InvalidatePossiblyObsoleteSlot()  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Hi,

Thanks for your detailed reply.

> I think that we could get rid of the initial_restart_lsn and just use
> s->data.restart_lsn here (while keeping initial xmin ones to preserve the
> intent of 818fefd8fd4 for those).

I agree with your proposed change.

> Your concern is only about the restart_lsn, right? (asking because I don't think
> it's safe not to rely on the initial_* for the xmin ones, see [1]).

My primary concern is indeed the restart_lsn issue, and thanks again for the clear explanation.

Best regards,
suyu.cmj



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: add function argument name to substring and substr
Next
From: Jim Jones
Date:
Subject: Re: Add notification on BEGIN ATOMIC SQL functions using temp relations