Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug - Mailing list pgsql-patches

From Hiroshi Saito
Subject Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug
Date
Msg-id 041801c6b117$6fc54040$e8100dde@IBMC4B5932F74B
Whole thread Raw
In response to Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
From: "Florian G. Pflug"

Ahhhhhhh, It is right.!
I was retracing my memory for what situations the contents were.
I was in distraction.....It seems that it is satisfactory at the reason for ==.

Sorry and Thanks.!!

Regards,
Hiroshi Saito

> Bruce Momjian wrote:
>>>> Why is this better than:
>>>>
>>>>   #if _MSC_VER == 1400
>>>>
>>>>
>>>> Surely this will not be true if _MSC_VER is undefined?
>>> I experienced injustice and the reason of in OSX for it.
>>
>> What was the problem with OSX?  Did it throw a warning of you did an
>> equality test on an undefined symbol?
>
> The following if evaluated to true on osx, although I'm pretty sure that
> _MSC_VER isn't defined on osx ;-)
> #if (_MSC_VER < 1300)
> ...
> #endif
>
> replacing it with
> #ifdef WIN32
> #if (_MSC_VER < 1300)
> ...
> #endif
> #endif
>
> fixed the problem.
>
> greetings, Florian Pflug


pgsql-patches by date:

Previous
From: "Florian G. Pflug"
Date:
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug
Next
From: Tatsuo Ishii
Date:
Subject: pgbench patches