Re: Detect buffer underflow in get_th() - Mailing list pgsql-hackers

From Alexander Kuznetsov
Subject Re: Detect buffer underflow in get_th()
Date
Msg-id 03df4973-3595-4078-a075-636bbb121f61@altlinux.org
Whole thread Raw
In response to Re: Detect buffer underflow in get_th()  (Alexander Kuznetsov <kuznetsovam@altlinux.org>)
List pgsql-hackers
Hello,

is there anything else we can help with or discuss in order to apply this fix?

24.07.2024 18:53, Alexander Kuznetsov пишет:
> 
> 24.07.2024 18:39, Peter Eisentraut wrote:
>> If it can't happen in practice, maybe an assertion would be enough?
>>
> 
> In practice, the function should not receive non-numeric strings either; however, since there is an exception in
placefor such cases, I thought it would be good to add a check for zero-length input in a similar manner.
 
> 
> But of course it's open for discussion and team decision whether this should be addressed as an assertion or handled
differently.
> 

-- 
Best regards,
Alexander Kuznetsov



pgsql-hackers by date:

Previous
From: Alexander Kuznetsov
Date:
Subject: Re: Possible null pointer dereference in afterTriggerAddEvent()
Next
From: Christoph Berg
Date:
Subject: Re: pgsql: Improve default and empty privilege outputs in psql.