Small issues in syncrep.c - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Small issues in syncrep.c
Date
Msg-id 02da4df2-0e47-aa83-cc65-271583ed3cbe@dalibo.com
Whole thread Raw
Responses Re: Small issues in syncrep.c  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Hello,

Since 14e8803f1, it's not necessary to acquire the SyncRepLock to see up
to date data. But it looks like this commit didn't update all the
comment around MyProc->syncRepState, which still mention retrieving the
value without and without lock.  Also, there's I think a now unneeded
test to try to retrieve again syncRepState.

Patch attached to fix both small issues, present since 9.5.

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Logical Replication WIP
Next
From: Vladimir Sitnikov
Date:
Subject: Re: Slowness of extended protocol