Re: remove unnecessary include in src/backend/commands/policy.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: remove unnecessary include in src/backend/commands/policy.c
Date
Msg-id 02d48c6a-1279-47a8-9154-f88c98067a90@eisentraut.org
Whole thread
In response to Re: remove unnecessary include in src/backend/commands/policy.c  (Shinya Kato <shinya11.kato@gmail.com>)
List pgsql-hackers
On 12.02.26 03:05, Shinya Kato wrote:
> On Sun, Jan 4, 2026 at 4:47 AM Kirill Reshke <reshkekirill@gmail.com> wrote:
>> We also can reflect that our new coding practice is to use table/index
>> open over relation_open in the commit message (I guess so after[0]).
> 
> Thanks for the review. I've updated the commit message.

I don't understand the point of this patch.  It changes some 
relation_open() calls to table_open().  The only difference of 
table_open() is that it checks the relkind.  But in these cases, the 
relkind was already checked earlier via RangeVarCallbackForPolicy.  So 
this change has no effect, but it adds extra overhead.




pgsql-hackers by date:

Previous
From: David Geier
Date:
Subject: Cleaning up array_ref() and array_set()
Next
From: Ajin Cherian
Date:
Subject: Re: [PATCH] Support automatic sequence replication