Hi Nathan
On 23/10/2025 23:02, Nathan Bossart wrote:
> My first thought when looking at this thread/patch was that something like
> "read-write" might be a bit long for a psql prompt. I probably would've
> chosen something like "r" or "ro" for read-only and "rw" for read-write. I
> suppose you could argue that those are more difficult to see, and this
> seems particularly useful when you want to be sure that you won't
> inadvertently write any data.
I can see the appeal of keeping the indicator as short as possible in a
prompt, but that can also make it a bit harder to quickly distinguish
between the read/write and read-only states. In this case, clarity might
be more important than compactness. Then again, the traditional shell
prompt symbols ($, #) aren't exactly self-explanatory either, and people
seem fine with those :)
Although I prefer it being explicit in this case, I can live with either
approach. Do you think we should go for "ro" or "rw"?
Thanks for the review!
Best, Jim
