Re: Non-text mode for pg_dumpall - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Non-text mode for pg_dumpall
Date
Msg-id 016819c0-666e-42a8-bfc8-2b93fd8d0176@eisentraut.org
Whole thread Raw
In response to Re: Non-text mode for pg_dumpall  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Non-text mode for pg_dumpall
List pgsql-hackers
I noticed this cast in the committed code:

> + num_total_db = get_dbname_oid_list_from_mfile((char *) inputFileSpec, 
> &dbname_oid_list);

The cast drops the const qualifier from inputFileSpec. 
get_dbname_oid_list_from_mfile() writes into the space pointed to by its 
argument, so it's really not "const".  (And inputFileSpec points into 
argv, so this ends up writing directly into argv.)

Please see if you can clean this up.  It might be best if 
get_dbname_oid_list_from_mfile() made a copy of its argument that it can 
write into, and then the argument can be "const".




pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: BUG: Former primary node might stuck when started as a standby
Next
From: shveta malik
Date:
Subject: Re: Skipping schema changes in publication