Re: Additional fixes to ecpg - please apply patch - Mailing list pgsql-interfaces

From Nicolas Bazin
Subject Re: Additional fixes to ecpg - please apply patch
Date
Msg-id 00c101c1c89d$dfd148a0$660d090a@software.ingenico.com.au
Whole thread Raw
In response to Additional fixes to ecpg - please apply patch  ("Nicolas Bazin" <nbazin@ingenico.com.au>)
Responses Re: Subject: Re: Additional fixes to ecpg - please apply patch
List pgsql-interfaces
It works except that you overwrote a previous patch I submitted that was already applied (see mail joined).
Sorry for sending you a diff in the wrong order.
Also I though the type definition syntax could be enhanced. Instaead of defining
EXEC SQL type mytype is struct {
...
};
typedef struct {
...
} mytype;
 
It would be better to allow the following:
EXEC SQL begin declare section;
typedef struct {
...
} mytype;
 
EXEC SQL end declare section;
 
Both syntax can be maintained for compatibility of existing application, but I find 
the second one easier to maintain because there is no code duplication.
 
Can you do it ? 
 
Nicolas
 
 
On Fri, Mar 08, 2002 at 06:35:18PM +1100, Nicolas Bazin wrote:
> This new patch corrects 2 new bugs:

Slighlty differently fixed this in CVS.

Thanks for reporting the bugs. Please tell me of my fix is not
sufficient.

Michael
-- 
Michael Meskes
Michael@Fam-Meskes.De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

 
Please apply patch.
----- Original Message -----
Sent: Tuesday, March 05, 2002 12:08 PM
Subject: Re: BUG#599 & BUG 606 correction

The end of a define section is tested too soon during the parsing of ecpg. This patch makes sure that the parser only do the test at the end of the file being parsed.
 
Please apply this patch to src/interface/ecpg/preproc/pgc.l
 
Nicolas BAZIN
Attachment

pgsql-interfaces by date:

Previous
From: Michael Meskes
Date:
Subject: Re: Additional fixes to ecpg - please apply patch
Next
From: Αλέξανδρος Περδικομάτης
Date:
Subject: Re: Problem trying to connect to a database with PGACCESS