Re: Proposal for Allow postgresql.conf values to be changed via SQL - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Proposal for Allow postgresql.conf values to be changed via SQL
Date
Msg-id 00a301cdd78c$faac6dd0$f0054970$@kapila@huawei.com
Whole thread Raw
In response to Re: Proposal for Allow postgresql.conf values to be changed via SQL  (Jaime Casanova <jaime@2ndquadrant.com>)
Responses Re: Proposal for Allow postgresql.conf values to be changed via SQL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tuesday, December 11, 2012 5:25 AM Jaime Casanova wrote:
> On Fri, Nov 23, 2012 at 4:56 AM, Amit Kapila <amit.kapila@huawei.com>
> wrote:
> > On Thursday, November 22, 2012 10:09 PM Fujii Masao wrote:
> >
> >> Is it helpful to output the notice message like 'Run pg_reload_conf()
> or
> >> restart the server if you want new settings to take effect' always
> after
> >> SET PERSISTENT command?
> >
> > Not sure because if someone uses SET PERSISTENT command, he should
> know the
> > effect or behavior of same.
> > I think it's good to put this in UM along with "PERSISTENT" option
> > explanation.
> >
> 
> can we at least send the source file in the error message when a
> parameter has a wrong value?
> 
> suppose you do: SET PERSISTENT shared_preload_libraries TO
> 'some_nonexisting_lib';
> when you restart postgres and that lib doesn't exist you can get
> confused when looking at postgresql.conf and find an empty string
> there

This can be done but for this we need to change internal functions
internal_load_library 
initialize_SSL 
postmastermain

The same information needs to be provided for some other parameters also
like 'listen_address', etc. 
which are not validated during the configuration parameter set.

How about giving some Warning/Notice message for all postmaster specific
configuration parameters during set persistent as if any problem occurs
during restart please verify the postgresql.auto.conf file? 
Also Provide information in User manual as how to recover from such problems
occurs because of postgresql.auto.conf?

With Regards,
Amit Kapila.




pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: allowing multiple PQclear() calls
Next
From: Pavel Stehule
Date:
Subject: skipping context for RAISE statements - maybe obsolete?