Re: SVN Commit by dpage: r5106 - in trunk/pgadmin3: - Mailing list pgadmin-hackers

From Dave Page
Subject Re: SVN Commit by dpage: r5106 - in trunk/pgadmin3:
Date
Msg-id 008901c66d1e$e2168527$6a01a8c0@valehousing.co.uk
Whole thread Raw
Responses Re: SVN Commit by dpage: r5106 - in trunk/pgadmin3:  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgadmin-hackers
-----Original Message-----
From: "Andreas Pflug"<pgadmin@pse-consulting.de>
Sent: 01/05/06 13:29:00
To: "Dave Page"<dpage@vale-housing.co.uk>
Cc: "svn@pgadmin.org"<svn@pgadmin.org>, "pgadmin-hackers@postgresql.org"<pgadmin-hackers@postgresql.org>
Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r5106 - in trunk/pgadmin3:


> AFAICS this is basically a plain copy of the backend version? If so, I'd
> prefer to have it stored in the db directory, where we already have the
> unchanged keywords.c. All backend extracted sources should be upgradable
> from pgsql HEAD by simply copying them.

md5.c(pp) is unchanged, bar the top comment. md5.h is custom though. I have no problem moving them.

/D

-----Unmodified Original Message-----
Dave Page wrote:

>
>
> I considered this carefully and chose that method for a few reasons.

'k, after having a look what you did a I found you copied the backend's
version. I agree with your arguments.

AFAICS this is basically a plain copy of the backend version? If so, I'd
prefer to have it stored in the db directory, where we already have the
unchanged keywords.c. All backend extracted sources should be upgradable
from pgsql HEAD by simply copying them.

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: "Dave Page"
Date:
Subject: Re: CHANGELOG
Next
From: Andreas Pflug
Date:
Subject: Re: CHANGELOG