Re: [HACKERS] Source code format vote - Mailing list pgsql-hackers

From J. Roeleveld
Subject Re: [HACKERS] Source code format vote
Date
Msg-id 008801bf529d$d54d0180$8402a8c0@sentec.demon.nl
Whole thread Raw
In response to Source code format vote  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] Source code format vote
List pgsql-hackers
> > Current votes are:
> >
> > (8)     8-space tabs:   Tom Lane, Peter E., Massimo, Jan, Hiroshi, Peter
M.,
> >                         Michael, Tatsuo
> > (5)     4-space tabs:   Bruce, Andreas, Vince, Vadim, D'Arcy
> >
> >
> >         open bracket on if () line:
> > (7)     yes:    Massimo, Peter, Vince, Tom Lane, Peter M., Marc, Tatsuo
> > (6)     no:     Bruce, Vadim, D'Arcy, Jan, Hiroshi, Michael M.
> >
> > Looks like radical change will come to our source code format for 7.0.
> >
> > Unless someone else speaks up, I will consider this vote closed.  I will
> > modify pgindent to reflect this format the next time it is run.
>
> Don't know if I qualify to vote - but if I do then I vote for 4-space tabs
> (seeing that I often read the code - now if only two-space tabs
> were an option...)

Same here, I prefer 4-space tabs as well, looks much better on standard
screens.
Also I personally prefer the open bracket not to be placed in the if() line.

But I'm not sure if I qualify to vote either, although I do read the code.

Joost Roeleveld



pgsql-hackers by date:

Previous
From: Theo Kramer
Date:
Subject: Re: [HACKERS] Source code format vote
Next
From: "Ansley, Michael"
Date:
Subject: RE: [HACKERS] Source code format vote