Re: DOCS - Clarify the publication 'publish_via_partition_root' default value. - Mailing list pgsql-hackers

From Chao Li
Subject Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.
Date
Msg-id 007F9678-3258-4989-8B20-BAEA7A728B99@gmail.com
Whole thread Raw
In response to Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers

> On Dec 12, 2025, at 07:12, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>
> On Thu, Dec 11, 2025 at 12:22 PM Peter Smith <smithpb2250@gmail.com> wrote:
>>> Why not just say clearly what the default value is?
>>>
>>> PSA: a patch to do that.
>
> LGTM. (In fact I've read that paragraph three times and still cannot
> get it to stick in my head, despite having done a fair amount of
> thinking about publish_via_partition_root, so if you have further
> improvement ideas I'm all ears.)
>
> --Jacob
>
>

My feeling is that the preceding long sentence has described both sides expect explicitly mentioning true and false,
whichmakes the following sentence, no matter the original version and the patched version sounds slightly redundant. So
Ithink maybe we can rework the entire paragraph like: 

```
This parameter controls how changes to a partitioned table (or any of its partitions) are published. When set to true,
changesare published using the identity and schema of the partitioned table. When set to false (the default), changes
arepublished using the identity and schema of the individual partitions 
where the changes actually occurred. Enabling this option allows the changes to be replicated into a non-partitioned
tableor into a partitioned table whose 
partition structure differs from that of the publisher.
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: pg_plan_advice
Next
From: Gyan Sreejith
Date:
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber