RE: [HACKERS] freefuncs.c is never called from anywhere!? - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject RE: [HACKERS] freefuncs.c is never called from anywhere!?
Date
Msg-id 001101bf6b7e$c948b560$2801007e@tpf.co.jp
Whole thread Raw
In response to Re: [HACKERS] freefuncs.c is never called from anywhere!?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] freefuncs.c is never called from anywhere!?
List pgsql-hackers
> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> 
> "Hiroshi Inoue" <Inoue@tpf.co.jp> writes:
> > As far as I see,freeObject() has a fundamental problem.
> > Probably it couldn't free multiple references safely.
> 
> Yes, that code will have a problem with node trees that have
> circular references or multiple links to the same node.
> Both of which are cases that we can currently generate :-(.
> 
> Of course, circular links will also break copyfuncs, equalfuncs,
> and printfuncs.  We have a known bug with the backend crashing
> when -d is enabled for certain queries, because of infinite
> recursion in printfuncs.
>

Multiple links to the same node is not so fatal for other xxxxObject().
In fact they are used without big problem.
But isn't it fatal for freeObject() ?

Regards.

Hiroshi Inoue
Inoue@tpf.co.jp


pgsql-hackers by date:

Previous
From: "Hiroshi Inoue"
Date:
Subject: RE: ImmediateSharedRelationCacheInvalidate considered harmful
Next
From: Chris Bitmead
Date:
Subject: Re: [HACKERS] Re: ORDBMS