From 5f11a221d2ee661d15cdd6216aa7bd3045969a01 Mon Sep 17 00:00:00 2001 From: Shinya Kato Date: Thu, 11 Jun 2026 16:02:03 +0900 Subject: [PATCH v1 1/5] Add pg_stat_deprecated_features view PostgreSQL has no way to measure whether deprecated features are still in use before they are removed, forcing such decisions to be made blind or based on log scraping. Add a new cumulative statistics kind for deprecated feature usage and expose it through a new pg_stat_deprecated_features view, with one row per tracked feature showing a usage count and the time of last use. Statistics are cluster-wide, persist across clean restarts, and can be reset with pg_stat_reset_shared('deprecated_features'). This commit only adds the statistics infrastructure, the registry of tracked features, and the view itself; the per-feature counting hooks that call pgstat_count_deprecated_feature() are added by subsequent commits, so all usage counts are zero for now. Bump catalog version. Bump PGSTAT_FILE_FORMAT_ID. Author: Shinya Kato Reviewed-by: Discussion: https://postgr.es/m/ --- doc/src/sgml/monitoring.sgml | 114 ++++++++++++ src/backend/catalog/system_views.sql | 8 + src/backend/utils/activity/Makefile | 1 + src/backend/utils/activity/meson.build | 1 + src/backend/utils/activity/pgstat.c | 17 ++ .../activity/pgstat_deprecated_features.c | 175 ++++++++++++++++++ src/backend/utils/adt/pgstatfuncs.c | 50 ++++- src/include/catalog/pg_proc.dat | 9 + src/include/pgstat.h | 27 ++- src/include/utils/pgstat_internal.h | 20 ++ src/include/utils/pgstat_kind.h | 9 +- src/test/regress/expected/rules.out | 5 + src/test/regress/expected/stats.out | 22 ++- src/test/regress/sql/stats.sql | 8 + 14 files changed, 459 insertions(+), 7 deletions(-) create mode 100644 src/backend/utils/activity/pgstat_deprecated_features.c diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 08d5b824552..25f993496d8 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -499,6 +499,15 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser + + pg_stat_deprecated_featurespg_stat_deprecated_features + + One row per deprecated feature, showing cluster-wide usage statistics. + See + pg_stat_deprecated_features for details. + + + pg_stat_iopg_stat_io @@ -3397,6 +3406,105 @@ description | Waiting for a newly initialized WAL file to reach durable storage + + <structname>pg_stat_deprecated_features</structname> + + + pg_stat_deprecated_features + + + + The pg_stat_deprecated_features view will contain + one row for each deprecated feature whose usage is tracked, showing + cluster-wide usage statistics. This allows administrators to determine + whether anything still depends on a deprecated feature before it is + removed. + + + + Depending on the feature, usage is counted when SQL making use of the + feature is parsed, when a command using the feature is executed, or when + an authentication exchange relying on the feature succeeds. For features + counted at parse time, re-executing a prepared statement does not + increment the counter again. Counting happens regardless of whether a + warning about the feature's use is emitted; for example, MD5 password + usage is counted even when is + disabled. + + + + <structname>pg_stat_deprecated_features</structname> View + + + + + + Column Type + + + Description + + + + + + + + + name text + + + Name of the deprecated feature. + + + + + + + + usage_count bigint + + + Number of times the deprecated feature has been used. + + + + + + + + last_used timestamp with time zone + + + Time at which the deprecated feature was last used, or + NULL if it has not been used since these + statistics were last reset. + + + + + + + + stats_reset timestamp with time zone + + + Time at which these statistics were last reset. + + + + + +
+ + + The tracked deprecated features are: + + + + + + <structname>pg_stat_bgwriter</structname> @@ -5654,6 +5762,12 @@ description | Waiting for a newly initialized WAL file to reach durable storage pg_stat_checkpointer view. + + + deprecated_features: Reset all the counters shown + in the pg_stat_deprecated_features view. + + io: Reset all the counters shown in the diff --git a/src/backend/catalog/system_views.sql b/src/backend/catalog/system_views.sql index 8f129baec90..025b5aa9f02 100644 --- a/src/backend/catalog/system_views.sql +++ b/src/backend/catalog/system_views.sql @@ -1012,6 +1012,14 @@ CREATE VIEW pg_stat_lock AS l.stats_reset FROM pg_stat_get_lock() l; +CREATE VIEW pg_stat_deprecated_features AS + SELECT + d.name, + d.usage_count, + d.last_used, + d.stats_reset + FROM pg_stat_get_deprecated_features() d; + CREATE VIEW pg_stat_wal_receiver AS SELECT s.pid, diff --git a/src/backend/utils/activity/Makefile b/src/backend/utils/activity/Makefile index ca3ef89bf59..c0168d536b5 100644 --- a/src/backend/utils/activity/Makefile +++ b/src/backend/utils/activity/Makefile @@ -24,6 +24,7 @@ OBJS = \ pgstat_bgwriter.o \ pgstat_checkpointer.o \ pgstat_database.o \ + pgstat_deprecated_features.o \ pgstat_function.o \ pgstat_io.o \ pgstat_lock.o \ diff --git a/src/backend/utils/activity/meson.build b/src/backend/utils/activity/meson.build index 1aa7ece5290..bf5cb21fcc2 100644 --- a/src/backend/utils/activity/meson.build +++ b/src/backend/utils/activity/meson.build @@ -9,6 +9,7 @@ backend_sources += files( 'pgstat_bgwriter.c', 'pgstat_checkpointer.c', 'pgstat_database.c', + 'pgstat_deprecated_features.c', 'pgstat_function.c', 'pgstat_io.c', 'pgstat_lock.c', diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index c4fa14f138f..919fdc0104f 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -432,6 +432,23 @@ static const PgStat_KindInfo pgstat_kind_builtin_infos[PGSTAT_KIND_BUILTIN_SIZE] .snapshot_cb = pgstat_checkpointer_snapshot_cb, }, + [PGSTAT_KIND_DEPRECATED_FEATURES] = { + .name = "deprecated_features", + + .fixed_amount = true, + .write_to_file = true, + + .snapshot_ctl_off = offsetof(PgStat_Snapshot, deprecated_features), + .shared_ctl_off = offsetof(PgStat_ShmemControl, deprecated_features), + .shared_data_off = offsetof(PgStatShared_DeprecatedFeatures, stats), + .shared_data_len = sizeof(((PgStatShared_DeprecatedFeatures *) 0)->stats), + + .flush_static_cb = pgstat_deprecated_features_flush_cb, + .init_shmem_cb = pgstat_deprecated_features_init_shmem_cb, + .reset_all_cb = pgstat_deprecated_features_reset_all_cb, + .snapshot_cb = pgstat_deprecated_features_snapshot_cb, + }, + [PGSTAT_KIND_IO] = { .name = "io", diff --git a/src/backend/utils/activity/pgstat_deprecated_features.c b/src/backend/utils/activity/pgstat_deprecated_features.c new file mode 100644 index 00000000000..47e34b78243 --- /dev/null +++ b/src/backend/utils/activity/pgstat_deprecated_features.c @@ -0,0 +1,175 @@ +/* ------------------------------------------------------------------------- + * + * pgstat_deprecated_features.c + * Implementation of deprecated feature usage statistics. + * + * This file contains the implementation of deprecated feature usage + * statistics. It is kept separate from pgstat.c to enforce the line + * between the statistics access / storage implementation and the details + * about individual types of statistics. + * + * Copyright (c) 2001-2026, PostgreSQL Global Development Group + * + * IDENTIFICATION + * src/backend/utils/activity/pgstat_deprecated_features.c + * ------------------------------------------------------------------------- + */ + +#include "postgres.h" + +#include "utils/pgstat_internal.h" +#include "utils/timestamp.h" + + +/* + * Names of the deprecated features that we keep usage statistics for. + * Entries are one-to-one with the PgStat_DeprecatedFeature enum and must + * be kept in the same order, sorted by name. + */ +static const char *const pgstat_deprecated_feature_names[] = { + /* entries are added by later commits */ +}; + +StaticAssertDecl(lengthof(pgstat_deprecated_feature_names) == PGSTAT_NUM_DEPRECATED_FEATURES, + "pgstat_deprecated_feature_names[] inconsistent with PgStat_DeprecatedFeature"); + +/* + * Deprecated feature usage counts waiting to be flushed out. We assume + * this variable inits to zeroes. Entries are one-to-one with + * pgstat_deprecated_feature_names[]. + */ +static PgStat_DeprecatedFeatureStats pending_DeprecatedFeatureStats[PGSTAT_NUM_DEPRECATED_FEATURES]; +static bool have_deprecated_feature_stats = false; + + +/* + * Count one use of a deprecated feature. + */ +void +pgstat_count_deprecated_feature(PgStat_DeprecatedFeature feature) +{ + PgStat_DeprecatedFeatureStats *pendingent; + + pgstat_assert_is_up(); + + /* + * The postmaster should never count deprecated feature usage; if it did, + * the counts would be duplicated into child processes via fork(). + */ + Assert(IsUnderPostmaster || !IsPostmasterEnvironment); + + Assert(feature < PGSTAT_NUM_DEPRECATED_FEATURES); + + pendingent = &pending_DeprecatedFeatureStats[feature]; + pendingent->usage_count++; + pendingent->last_used = GetCurrentTimestamp(); + + have_deprecated_feature_stats = true; + pgstat_report_fixed = true; +} + +/* + * Support function for the SQL-callable pgstat* functions. Returns + * a pointer to the deprecated feature usage statistics struct. + */ +PgStat_DeprecatedFeatureStats * +pgstat_fetch_deprecated_features(void) +{ + pgstat_snapshot_fixed(PGSTAT_KIND_DEPRECATED_FEATURES); + + return pgStatLocal.snapshot.deprecated_features; +} + +/* + * Returns the name of a deprecated feature for an index. The index may be + * above PGSTAT_NUM_DEPRECATED_FEATURES, in which case this returns NULL. + * This allows writing code that does not know the number of entries in + * advance. + */ +const char * +pgstat_get_deprecated_feature_name(int idx) +{ + if (idx < 0 || idx >= PGSTAT_NUM_DEPRECATED_FEATURES) + return NULL; + + return pgstat_deprecated_feature_names[idx]; +} + +/* + * Flush out locally pending deprecated feature usage stats entries + * + * If nowait is true, this function returns true if the lock could not be + * acquired. Otherwise return false. + */ +bool +pgstat_deprecated_features_flush_cb(bool nowait) +{ + PgStatShared_DeprecatedFeatures *stats_shmem = &pgStatLocal.shmem->deprecated_features; + int i; + + if (!have_deprecated_feature_stats) + return false; + + if (!nowait) + LWLockAcquire(&stats_shmem->lock, LW_EXCLUSIVE); + else if (!LWLockConditionalAcquire(&stats_shmem->lock, LW_EXCLUSIVE)) + return true; + + for (i = 0; i < PGSTAT_NUM_DEPRECATED_FEATURES; i++) + { + PgStat_DeprecatedFeatureStats *sharedent = &stats_shmem->stats[i]; + PgStat_DeprecatedFeatureStats *pendingent = &pending_DeprecatedFeatureStats[i]; + + sharedent->usage_count += pendingent->usage_count; + sharedent->last_used = Max(sharedent->last_used, + pendingent->last_used); + } + + /* done, clear the pending entry */ + MemSet(pending_DeprecatedFeatureStats, 0, + sizeof(pending_DeprecatedFeatureStats)); + + LWLockRelease(&stats_shmem->lock); + + have_deprecated_feature_stats = false; + + return false; +} + +void +pgstat_deprecated_features_init_shmem_cb(void *stats) +{ + PgStatShared_DeprecatedFeatures *stats_shmem = (PgStatShared_DeprecatedFeatures *) stats; + + LWLockInitialize(&stats_shmem->lock, LWTRANCHE_PGSTATS_DATA); +} + +void +pgstat_deprecated_features_reset_all_cb(TimestampTz ts) +{ + PgStatShared_DeprecatedFeatures *stats_shmem = &pgStatLocal.shmem->deprecated_features; + + LWLockAcquire(&stats_shmem->lock, LW_EXCLUSIVE); + + for (int i = 0; i < PGSTAT_NUM_DEPRECATED_FEATURES; i++) + { + memset(&stats_shmem->stats[i], 0, + sizeof(PgStat_DeprecatedFeatureStats)); + stats_shmem->stats[i].stat_reset_timestamp = ts; + } + + LWLockRelease(&stats_shmem->lock); +} + +void +pgstat_deprecated_features_snapshot_cb(void) +{ + PgStatShared_DeprecatedFeatures *stats_shmem = &pgStatLocal.shmem->deprecated_features; + + LWLockAcquire(&stats_shmem->lock, LW_SHARED); + + memcpy(pgStatLocal.snapshot.deprecated_features, &stats_shmem->stats, + sizeof(stats_shmem->stats)); + + LWLockRelease(&stats_shmem->lock); +} diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 6f9c9c72de5..5041e5cbfd8 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -1820,6 +1820,51 @@ pg_stat_get_slru(PG_FUNCTION_ARGS) return (Datum) 0; } +/* + * Returns statistics of deprecated feature usage. + */ +Datum +pg_stat_get_deprecated_features(PG_FUNCTION_ARGS) +{ +#define PG_STAT_GET_DEPRECATED_FEATURES_COLS 4 + ReturnSetInfo *rsinfo = (ReturnSetInfo *) fcinfo->resultinfo; + int i; + PgStat_DeprecatedFeatureStats *stats; + + InitMaterializedSRF(fcinfo, 0); + + /* request deprecated feature stats from the cumulative stats system */ + stats = pgstat_fetch_deprecated_features(); + + for (i = 0;; i++) + { + /* for each row */ + Datum values[PG_STAT_GET_DEPRECATED_FEATURES_COLS] = {0}; + bool nulls[PG_STAT_GET_DEPRECATED_FEATURES_COLS] = {0}; + PgStat_DeprecatedFeatureStats stat; + const char *name; + + name = pgstat_get_deprecated_feature_name(i); + + if (!name) + break; + + stat = stats[i]; + + values[0] = PointerGetDatum(cstring_to_text(name)); + values[1] = Int64GetDatum(stat.usage_count); + if (stat.last_used == 0) + nulls[2] = true; + else + values[2] = TimestampTzGetDatum(stat.last_used); + values[3] = TimestampTzGetDatum(stat.stat_reset_timestamp); + + tuplestore_putvalues(rsinfo->setResult, rsinfo->setDesc, values, nulls); + } + + return (Datum) 0; +} + #define PG_STAT_GET_XACT_RELENTRY_INT64(stat) \ Datum \ CppConcat(pg_stat_get_xact_,stat)(PG_FUNCTION_ARGS) \ @@ -1956,6 +2001,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS) pgstat_reset_of_kind(PGSTAT_KIND_ARCHIVER); pgstat_reset_of_kind(PGSTAT_KIND_BGWRITER); pgstat_reset_of_kind(PGSTAT_KIND_CHECKPOINTER); + pgstat_reset_of_kind(PGSTAT_KIND_DEPRECATED_FEATURES); pgstat_reset_of_kind(PGSTAT_KIND_IO); pgstat_reset_of_kind(PGSTAT_KIND_LOCK); XLogPrefetchResetStats(); @@ -1973,6 +2019,8 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS) pgstat_reset_of_kind(PGSTAT_KIND_BGWRITER); else if (strcmp(target, "checkpointer") == 0) pgstat_reset_of_kind(PGSTAT_KIND_CHECKPOINTER); + else if (strcmp(target, "deprecated_features") == 0) + pgstat_reset_of_kind(PGSTAT_KIND_DEPRECATED_FEATURES); else if (strcmp(target, "io") == 0) pgstat_reset_of_kind(PGSTAT_KIND_IO); else if (strcmp(target, "lock") == 0) @@ -1987,7 +2035,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS) ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE), errmsg("unrecognized reset target: \"%s\"", target), - errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\"."))); + errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"deprecated_features\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\"."))); PG_RETURN_VOID(); } diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 384ba908d35..2823f856424 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -6069,6 +6069,15 @@ proargnames => '{locktype,waits,wait_time,fastpath_exceeded,stats_reset}', prosrc => 'pg_stat_get_lock' }, +{ oid => '8987', descr => 'statistics: deprecated feature usage', + proname => 'pg_stat_get_deprecated_features', prorows => '0', + proretset => 't', provolatile => 'v', proparallel => 'r', + prorettype => 'record', proargtypes => '', + proallargtypes => '{text,int8,timestamptz,timestamptz}', + proargmodes => '{o,o,o,o}', + proargnames => '{name,usage_count,last_used,stats_reset}', + prosrc => 'pg_stat_get_deprecated_features' }, + { oid => '6386', descr => 'statistics: backend IO statistics', proname => 'pg_stat_get_backend_io', prorows => '5', proretset => 't', provolatile => 'v', proparallel => 'r', prorettype => 'record', diff --git a/src/include/pgstat.h b/src/include/pgstat.h index dfa2e837638..a43b56f247d 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -218,7 +218,7 @@ typedef struct PgStat_TableXactStatus * ------------------------------------------------------------ */ -#define PGSTAT_FILE_FORMAT_ID 0x01A5BCBC +#define PGSTAT_FILE_FORMAT_ID 0x01A5BCBD typedef struct PgStat_ArchiverStats { @@ -273,6 +273,22 @@ typedef struct PgStat_CheckpointerStats } PgStat_CheckpointerStats; +/* Deprecated features counted by pg_stat_deprecated_features */ +typedef enum PgStat_DeprecatedFeature +{ + /* entries are added by later commits */ +} PgStat_DeprecatedFeature; + +#define PGSTAT_NUM_DEPRECATED_FEATURES 0 + +typedef struct PgStat_DeprecatedFeatureStats +{ + PgStat_Counter usage_count; + TimestampTz last_used; + TimestampTz stat_reset_timestamp; +} PgStat_DeprecatedFeatureStats; + + /* * Types related to counting IO operations */ @@ -608,6 +624,15 @@ extern void pgstat_report_checkpointer(void); extern PgStat_CheckpointerStats *pgstat_fetch_stat_checkpointer(void); +/* + * Functions in pgstat_deprecated_features.c + */ + +extern void pgstat_count_deprecated_feature(PgStat_DeprecatedFeature feature); +extern const char *pgstat_get_deprecated_feature_name(int idx); +extern PgStat_DeprecatedFeatureStats *pgstat_fetch_deprecated_features(void); + + /* * Functions in pgstat_io.c */ diff --git a/src/include/utils/pgstat_internal.h b/src/include/utils/pgstat_internal.h index 3ca4f454895..24d2630a092 100644 --- a/src/include/utils/pgstat_internal.h +++ b/src/include/utils/pgstat_internal.h @@ -453,6 +453,13 @@ typedef struct PgStatShared_Checkpointer PgStat_CheckpointerStats reset_offset; } PgStatShared_Checkpointer; +typedef struct PgStatShared_DeprecatedFeatures +{ + /* lock protects ->stats */ + LWLock lock; + PgStat_DeprecatedFeatureStats stats[PGSTAT_NUM_DEPRECATED_FEATURES]; +} PgStatShared_DeprecatedFeatures; + /* Shared-memory ready PgStat_IO */ typedef struct PgStatShared_IO { @@ -576,6 +583,7 @@ typedef struct PgStat_ShmemControl PgStatShared_Archiver archiver; PgStatShared_BgWriter bgwriter; PgStatShared_Checkpointer checkpointer; + PgStatShared_DeprecatedFeatures deprecated_features; PgStatShared_IO io; PgStatShared_Lock lock; PgStatShared_SLRU slru; @@ -608,6 +616,8 @@ typedef struct PgStat_Snapshot PgStat_CheckpointerStats checkpointer; + PgStat_DeprecatedFeatureStats deprecated_features[PGSTAT_NUM_DEPRECATED_FEATURES]; + PgStat_IO io; PgStat_Lock lock; @@ -744,6 +754,16 @@ extern bool pgstat_database_flush_cb(PgStat_EntryRef *entry_ref, bool nowait); extern void pgstat_database_reset_timestamp_cb(PgStatShared_Common *header, TimestampTz ts); +/* + * Functions in pgstat_deprecated_features.c + */ + +extern bool pgstat_deprecated_features_flush_cb(bool nowait); +extern void pgstat_deprecated_features_init_shmem_cb(void *stats); +extern void pgstat_deprecated_features_reset_all_cb(TimestampTz ts); +extern void pgstat_deprecated_features_snapshot_cb(void); + + /* * Functions in pgstat_function.c */ diff --git a/src/include/utils/pgstat_kind.h b/src/include/utils/pgstat_kind.h index 2d78a029683..60e6380c9ef 100644 --- a/src/include/utils/pgstat_kind.h +++ b/src/include/utils/pgstat_kind.h @@ -35,10 +35,11 @@ #define PGSTAT_KIND_ARCHIVER 7 #define PGSTAT_KIND_BGWRITER 8 #define PGSTAT_KIND_CHECKPOINTER 9 -#define PGSTAT_KIND_IO 10 -#define PGSTAT_KIND_LOCK 11 -#define PGSTAT_KIND_SLRU 12 -#define PGSTAT_KIND_WAL 13 +#define PGSTAT_KIND_DEPRECATED_FEATURES 10 +#define PGSTAT_KIND_IO 11 +#define PGSTAT_KIND_LOCK 12 +#define PGSTAT_KIND_SLRU 13 +#define PGSTAT_KIND_WAL 14 #define PGSTAT_KIND_BUILTIN_MIN PGSTAT_KIND_DATABASE #define PGSTAT_KIND_BUILTIN_MAX PGSTAT_KIND_WAL diff --git a/src/test/regress/expected/rules.out b/src/test/regress/expected/rules.out index a65a5bf0c4f..0f87f482750 100644 --- a/src/test/regress/expected/rules.out +++ b/src/test/regress/expected/rules.out @@ -1939,6 +1939,11 @@ pg_stat_database_conflicts| SELECT oid AS datid, pg_stat_get_db_conflict_logicalslot(oid) AS confl_active_logicalslot, pg_stat_get_db_stat_reset_time(oid) AS stats_reset FROM pg_database d; +pg_stat_deprecated_features| SELECT name, + usage_count, + last_used, + stats_reset + FROM pg_stat_get_deprecated_features() d(name, usage_count, last_used, stats_reset); pg_stat_gssapi| SELECT pid, gss_auth AS gss_authenticated, gss_princ AS principal, diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index bbb1db3c433..1444b2eec9a 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -1119,6 +1119,26 @@ SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpoi t (1 row) +-- The deprecated features view should list the expected features +SELECT name FROM pg_stat_deprecated_features ORDER BY name COLLATE "C"; + name +------ +(0 rows) + +-- Test that reset_shared with deprecated_features specified as the stats type works +SELECT max(stats_reset) AS deprecated_features_reset_ts FROM pg_stat_deprecated_features \gset +SELECT pg_stat_reset_shared('deprecated_features'); + pg_stat_reset_shared +---------------------- + +(1 row) + +SELECT max(stats_reset) > :'deprecated_features_reset_ts'::timestamptz FROM pg_stat_deprecated_features; + ?column? +---------- + t +(1 row) + -- Test that reset_shared with recovery_prefetch specified as the stats type works SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset SELECT pg_stat_reset_shared('recovery_prefetch'); @@ -1164,7 +1184,7 @@ SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal; -- Test error case for reset_shared with unknown stats type SELECT pg_stat_reset_shared('unknown'); ERROR: unrecognized reset target: "unknown" -HINT: Target must be "archiver", "bgwriter", "checkpointer", "io", "lock", "recovery_prefetch", "slru", or "wal". +HINT: Target must be "archiver", "bgwriter", "checkpointer", "deprecated_features", "io", "lock", "recovery_prefetch", "slru", or "wal". -- Test that reset works for pg_stat_database and pg_stat_database_conflicts -- Since pg_stat_database stats_reset starts out as NULL, reset it once first so that we -- have a baseline for comparison. The same for pg_stat_database_conflicts as it shares diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql index 610fd21fae4..f0711c41a87 100644 --- a/src/test/regress/sql/stats.sql +++ b/src/test/regress/sql/stats.sql @@ -513,6 +513,14 @@ SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset SELECT pg_stat_reset_shared('checkpointer'); SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpointer; +-- The deprecated features view should list the expected features +SELECT name FROM pg_stat_deprecated_features ORDER BY name COLLATE "C"; + +-- Test that reset_shared with deprecated_features specified as the stats type works +SELECT max(stats_reset) AS deprecated_features_reset_ts FROM pg_stat_deprecated_features \gset +SELECT pg_stat_reset_shared('deprecated_features'); +SELECT max(stats_reset) > :'deprecated_features_reset_ts'::timestamptz FROM pg_stat_deprecated_features; + -- Test that reset_shared with recovery_prefetch specified as the stats type works SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset SELECT pg_stat_reset_shared('recovery_prefetch'); -- 2.47.3