From 8418f76079ddb589f9861a83059271b5eaceaf77 Mon Sep 17 00:00:00 2001 From: Andy Fan Date: Wed, 11 Sep 2024 12:21:39 +0800 Subject: [PATCH v20260912 2/4] Continue to remove some unnecesary strlen calls sprintf return the number of characters printed (not including the trailing `\0'), so it is exactly same as strlen. so we can reuse that value and avoid a strlen call. --- src/backend/utils/adt/datetime.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/backend/utils/adt/datetime.c b/src/backend/utils/adt/datetime.c index 8f25c15fcfc..83c3c85305b 100644 --- a/src/backend/utils/adt/datetime.c +++ b/src/backend/utils/adt/datetime.c @@ -4717,6 +4717,7 @@ EncodeInterval(struct pg_itm *itm, int style, char *str) int fsec = itm->tm_usec; bool is_before = false; bool is_zero = true; + int data_len; /* * The sign of year and month are guaranteed to match, since they are @@ -4774,11 +4775,11 @@ EncodeInterval(struct pg_itm *itm, int style, char *str) char sec_sign = (hour < 0 || min < 0 || sec < 0 || fsec < 0) ? '-' : '+'; - sprintf(cp, "%c%d-%d %c%" PRId64 " %c%" PRId64 ":%02d:", + data_len = sprintf(cp, "%c%d-%d %c%" PRId64 " %c%" PRId64 ":%02d:", year_sign, abs(year), abs(mon), day_sign, i64abs(mday), sec_sign, i64abs(hour), abs(min)); - cp += strlen(cp); + cp += data_len; cp = AppendSeconds(cp, sec, fsec, MAX_INTERVAL_PRECISION, true); *cp = '\0'; } @@ -4788,16 +4789,16 @@ EncodeInterval(struct pg_itm *itm, int style, char *str) } else if (has_day) { - sprintf(cp, "%" PRId64 " %" PRId64 ":%02d:", + data_len = sprintf(cp, "%" PRId64 " %" PRId64 ":%02d:", mday, hour, min); - cp += strlen(cp); + cp += data_len; cp = AppendSeconds(cp, sec, fsec, MAX_INTERVAL_PRECISION, true); *cp = '\0'; } else { - sprintf(cp, "%" PRId64 ":%02d:", hour, min); - cp += strlen(cp); + data_len = sprintf(cp, "%" PRId64 ":%02d:", hour, min); + cp += data_len; cp = AppendSeconds(cp, sec, fsec, MAX_INTERVAL_PRECISION, true); *cp = '\0'; } -- 2.43.0