diff --git a/src/include/port/pg_numa.h b/src/include/port/pg_numa.h index 40f1d324dcf..3b9a5b42898 100644 --- a/src/include/port/pg_numa.h +++ b/src/include/port/pg_numa.h @@ -24,9 +24,22 @@ extern PGDLLIMPORT int pg_numa_get_max_node(void); * This is required on Linux, before pg_numa_query_pages() as we * need to page-fault before move_pages(2) syscall returns valid results. */ +#ifdef USE_VALGRIND + +static inline void +pg_numa_touch_mem_if_required(uint64 tmp, char *ptr) +{ + volatile uint64 ro_volatile_var pg_attribute_unused(); + ro_volatile_var = *(volatile uint64 *) ptr; +} + +#else + #define pg_numa_touch_mem_if_required(ro_volatile_var, ptr) \ ro_volatile_var = *(volatile uint64 *) ptr +#endif + #else #define pg_numa_touch_mem_if_required(ro_volatile_var, ptr) \ diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp index 7ea464c8094..6b9a8998f82 100644 --- a/src/tools/valgrind.supp +++ b/src/tools/valgrind.supp @@ -180,3 +180,14 @@ Memcheck:Cond fun:PyObject_Realloc } + +# Querying NUMA node for shared memory requires touching the memory so +# that it gets allocated in the process. But we'll touch memory backing +# buffers, but that memory may be marked as noaccess for buffers that +# are not pinned. So just ignore that, we're not really accessing the +# buffers, for all places querying the NUMA status. +{ + pg_numa_touch_mem_if_required + Memcheck:Addr8 + fun:pg_numa_touch_mem_if_required +}